lib/deploy: Support locking deployment finalization #1841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, keep forgetting to try out the new GitHub draft PR feature. |
jlebon
changed the title
jlebon
force-pushed
the
pr/staging-paths
branch
2 times, most recently
from
5ccec0c
to
094ef46
Compare
|
Do we expect rpm-ostree will e.g. always write out this file when it starts? |
Yeah, so basically I'm thinking something like:
|
|
I guess we could always write out the file on boot... Hmm, this ties into coreos/rpm-ostree#1747 as well. E.g. if we're driven by an agent, then we could default to always locking finalization? Though I think I'd prefer making it explicit still and just let the "driver" part be about automatic updates and injecting info in |
Rather than wrapping each instance of `sd_journal_*` with `HAVE_SYSTEMD`, let's just add some convenience macros that are just no-op if we're not compiling with systemd.
This can happen if a deployment was staged and later cleaned up. Though just as a helper when debugging issues, let's explicitly mention that case.
Teach `ostree-finalize-staged.service` to check for a file in `/run` to determine if it should do the finalization. This will be used in RPM-OSTree, where we want to be able to separate out "preparing updates" from "making update the default" for more fine-grained control. See: coreos/rpm-ostree#1748
jlebon
force-pushed
the
pr/staging-paths
branch
from
094ef46
to
b003fcd
Compare
jlebon
changed the title
jlebon
changed the title
|
OK, this one should be good to go! |
This was referenced Apr 24, 2019
Closed
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 24, 2019
This can happen if a deployment was staged and later cleaned up. Though just as a helper when debugging issues, let's explicitly mention that case. Closes: #1841 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 24, 2019
Teach `ostree-finalize-staged.service` to check for a file in `/run` to determine if it should do the finalization. This will be used in RPM-OSTree, where we want to be able to separate out "preparing updates" from "making update the default" for more fine-grained control. See: coreos/rpm-ostree#1748 Closes: #1841 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach
ostree-finalize-staged.serviceto check for a file in/runtodetermine if it should do the finalization. This will be used in
RPM-OSTree, where we want to be able to separate out "preparing updates"
from "making update the default" for more fine-grained control. See:
coreos/rpm-ostree#1748